MiSTer-devel / SNES_MiSTer

SNES for MiSTer
GNU General Public License v3.0
202 stars 81 forks source link

Hook - fastrom hack visual glitch #357

Closed leonquest closed 1 year ago

leonquest commented 1 year ago

Played this fastrom hack on the latest version, and noticed graphical glitches on the story sequence right after the first battle with capt hook.

Wrote the hack owner and he mentions could not recreate it on snes9x.

I'm looking to recreate it on real hardware, but haven't found working cheats for level select.

birdybro commented 1 year ago

Snes9x specifically has many inaccuracies when compared to original hardware. Can you test with Higan instead and report back?

leonquest commented 1 year ago

Snes9x specifically has many inaccuracies when compared to original hardware. Can you test with Higan instead and report back?

I need to find usable cheat codes to test on real hardware, but haven't found one yet.

birdybro commented 1 year ago

So it doesn't run on Higan without cheat codes? I'm surprised it runs at all on the MiSTer core then.

leonquest commented 1 year ago
birdybro commented 1 year ago

Ah got it, I requested that you test it in Higan, hence my confusion toward your response.

Why are you not willing to test with Higan? snes9x is known to be inaccurate when compared to original hardware, as compared to Higan. snes9x has compatibility with specific methods of hacks that will only work on snes9x as well. The MiSTer core uses much of the documentation from no$ and from bsnes (now Higan) for it's design and as such is made to be very accurate to original hardware. Therefore, snes9x shouldn't really be used as a base of comparison for what the MiSTer core ought to do.

leonquest commented 1 year ago

Please read my first post carefully

birdybro commented 1 year ago

I did. You played a fastrom hack, it got graphical glitches on a later level in the game, and you mentioned the author of the hack couldn't recreate the bug in snes9x, which is an inaccurate emulator that caters to behavior that isn't present on real hardware, by design, for hacks. The developers of these hacks should probably stop using snes9x if they want it to work on original hardware, personally, but that's another issue. Hopefully you can figure out how to get to that level again somehow (that game isn't easy :P).

leonquest commented 1 year ago

Tested on a 1CHIP Fat snes with an SD2Snes rev H, no glitching after the first battle with hook. I used all kinds of cheats to get there in half an hour, as unfortunately there are no GG codes out there yet for level skip or level select, and the supposed code left in the game by devs does not work.

Now, to fully confirm can someone else test again on a mister? I might find time again in the near future but maybe not today.

Word of advice if you use cheats to recreate quickly, turn them off right after finishing each stage otherwise the game will score you infinitely until it is able to drain your time, health and flying meter.

birdybro commented 1 year ago

Thanks for the thorough testing.

leonquest commented 1 year ago

Thanks to the cheats I was able to re-test relatively quick on mister.

Tested both a clean no-intro version and the fastrom hack. Could not reproduce it 🤷. I'm not sure what happened the first time, maybe it was a one-off or maybe it's part of the game's code.

Will shamefully close this one out.

birdybro commented 1 year ago

No shame at all! :)