MiSTer-devel / Saturn_MiSTer

Sega Saturn for MiSTer
51 stars 13 forks source link

Rayman (USA) // REGRESSION - Missing some CDDA audio frames when reading some tracks (CHD only) #141

Closed Zet-sensei closed 4 months ago

Zet-sensei commented 4 months ago

With recent changes to SCSP (commit https://github.com/MiSTer-devel/Saturn_MiSTer/commit/f0aa89a9d7e4be232a237c053d9aa438bff9b5fe), CDDA tracks in several games like Rayman (one of the most striking examples) are now played with some audio frames too late.

Confirmed also by another user on Discord.

Tested with Main MiSTer Unstable version 2024-02-28 and core version 2024-02-29

Zet-sensei commented 4 months ago

Further investigations are necessary. Will update the problem report accordingly.

Zet-sensei commented 4 months ago

After some more tests, the recent commit (2024-02-28) on Main MiSTer should be at fault https://github.com/MiSTer-devel/Main_MiSTer/commit/29fb8196ac8d97efd64be0c96571e3fab92c4593

If I revert to MiSTer Unstable Main 20240225, the issue is gone. And if I try once more to change it back to MiSTer Unstable Main 20240229, the problem reappears.

Maybe some changes on the decode INDEX commands to check ? As the INDEX 01 on that game isn't constant between CDDA tracks (either 00:02:00 INDEX01 or 00:02:02 INDEX01).

Tested with a CHD version of the game.

Zet-sensei commented 4 months ago

After some tests with a Redump formated version of the game, the issue isn't present anymore (decompressing the same CHD file to multiple BIN files + single CUE file).

Reverting to a 2024-02-25 version of the Main MiSTer file, we could load the two versions of the game without the issue too.

real-amano commented 4 months ago

https://github.com/MiSTer-devel/Main_MiSTer/pull/879 CHD compatibility seems to be in place now. Or at least improved.

BTW, if somebody tested Rayman again, could you check if issue #4 is still not fixed?

Zet-sensei commented 4 months ago

Not fixed for both issues. I'm already checking regulary my opened issues, thanks.

Zet-sensei commented 4 months ago

Tested and confirmed as fixed with an upcoming PR (https://github.com/MiSTer-devel/Main_MiSTer/pull/880) on the Main MiSTer file.