search

MiSTer-devel / Scripts_MiSTer

Miscellaneous Bash scripts for MiSTer
GNU General Public License v3.0
85 stars 43 forks source link

MRA check fails. #115

Open sorgelig opened 5 months ago

sorgelig commented 5 months ago

@theypsilon it seems github deprecated Ubuntu 18 which affects this script: https://raw.githubusercontent.com/MiSTer-devel/Scripts_MiSTer/master/other_authors/mra_rom_check.sh

So MRA validating gets failed now.

theypsilon commented 5 months ago

Could you point me to a job that fails? I've been searching but don't recall which one could be affected

sorgelig commented 5 months ago

https://github.com/MiSTer-devel/Arcade-Druaga_MiSTer/actions/runs/9249817984

theypsilon commented 5 months ago

The issue is the runtime on GitHub actions' workflow, I've sent a PR to use Ubuntu latest instead of 18.04: https://github.com/MiSTer-devel/Arcade-Druaga_MiSTer/pull/32

I already did this change in many workflows but this one was missing.

sorgelig commented 5 months ago

hmm.. I've thought it's centralized. Then there are some other repos with similar issue but it will be hard to find till i will get that error again.

theypsilon commented 5 months ago

The runtime is defined in each workflow, and that affects whatever is being run by the task. I was surprised when GitHub dropped support for such a popular distro. Very disappointing, it basically forces all long-lasting GitHub Action users to move to ubuntu-latest which is not the best for build reproducibility. I already changed all the repos to which I have access.