MiSTer-devel / TurboGrafx16_MiSTer

TurboGrafx-16 CD / PC Engine CD for MiSTer
94 stars 57 forks source link

Order of the Griffon password screen does not display the capital letters #170

Closed dshadoff closed 2 years ago

dshadoff commented 2 years ago

This is due to Order of the Griffon failing to initialize the palette; these characters are referencing an uninitialized palette entry - however, these values are apparently non-zero.

  1. When playing from a Turbo Everdrive on real hardware, this is also showing as black-on-black, as the TED menu initializes the palette at boot. (Same as MiSTer).
  2. When playing on Mednafen, this was 'fixed' on the recent 1.29.0 release. The related code initializes the palette as follows:
    for(unsigned i = 0; i < 0x200; i++)
    {
    color_table[i] = ((i ^ (i >> 3)) & 1) ? 0x000 : 0x1FF;
    FixPCache(i);
    }

    However, this initializes all entries to either black or bright white; on real hardware, the capital letters may appear as a very light shade of blue, or the same light green as the lowercase letters, or as white (depending on the boot).

dshadoff commented 2 years ago

This is palette entry 0xFF (character graphics), and is probably uninitialized due to an off-by-one bug in the game, failing to initialize it (but because the power-up value is non-zero, this seems to have been overlooked).

dshadoff commented 2 years ago

Pull request submitted. If other games are found to have palette initialization issues, the .mif file can be updated.

dshadoff commented 2 years ago

Fix is now in the released version.