MiSTer-devel / ao486_MiSTer

ao486 port for MiSTer
Other
262 stars 69 forks source link

Composite support for the new YC framework implementation? #135

Open eobet opened 9 months ago

eobet commented 9 months ago

In this thread, a number of people are using AO486 on regular CRT displays by adjusting the MisterFPGA.ini to add custom video modes for that core:

https://misterfpga.org/viewtopic.php?t=2574&sid=094fb15daf3d7d8b34d4de95a10ff2ea

This used to work well with component and even with the old implementation for composite signals. However, with the new composite implementation which supports the active adapters, there seems to be no way to get color so that seems to be a regression.

sorgelig commented 8 months ago

PC is originally made not for TV. Resolutions are too high. There is one more problem: due to many resolutions ao486 uses uneven pixel clock, so HDMI output is required because MiSTer scaler take care of uneven pixel clock and convert it to correct resolution.

eobet commented 8 months ago

PC is originally made not for TV. Resolutions are too high.

I understand that and MikeS told me something similar on Discord, but regardless this did work before the new YC framework was implemented and now it is broken (black and white only).

For those of us with either regular CRTs or PVMs, who enjoyed AO486 over composite before with the passive adapters, it would be nice if that functionality was restored for the active adapters even if just as a hidden option, regardless of how potentially hacky or theoretically incorrect it was.

sorgelig commented 8 months ago

YC mode doesn't work with vga_scaler=1 mode. YC works only with original video which is incompatible due to problems i described above. YC also requires a specific value for parameter which works only with one video clock while ao486 generates many resolutions with different frame rates, so video_adjust=1/2 modes will break it. All-in-all ao486 is not for TV, and especially not for composite.

eobet commented 8 months ago

All-in-all ao486 is not for TV, and especially not for composite.

You might say this, but it did work before and now it doesn't. See this post which is mine:

https://misterfpga.org/viewtopic.php?p=68312#p68312

On Discord @MikeS11 also had the same unfortunate position on this issue, but hopefully someone else in the future who is also a fan of composite will see this issue and have the time and knowledge to add back the old or figure out a new (possibly hacky way, I don't care as AO486 is super hacky anyway) method of getting AO486 to once again display correctly on CRTs using MiSTer... 🙏