search

MiSTerArch / PKGBUILDs

Arch Linux ARM packages to run MiSTer
17 stars 1 forks source link

"Fix" for dkms #18

Closed tcamargo closed 2 years ago

tcamargo commented 2 years ago

Fixes #17.

amstan commented 2 years ago

So what was the actual change required? I see you did a bunch of config changes, added "ARCH=arm" (which i'm surprised was required, other arch packages are compiled the same way, on device). Then you built it on an arm system (which I imagined was one of the ways to work that this bug would be solved fully).

What are those .config changes for?

PS: Can you have one commit in the future that does both? And perhaps include the package version in the name. See git history for examples.

tcamargo commented 2 years ago

I'm not really sure. Your changes here don't really do much. The big change actually required to fix the bug (well, the most straightforward option) is moving the compilation to a native-compiler, not a cross-compiler. And for that we don't really need anything but the pkrev bump.

pkgrel and config changes. Disregards the ARCH thing.

On the other hand the compilation time will probably go up. My bar is the 5 min ish time.

Could you try to generate mister-headers inside chroot? I only have 2 cores assigned to my archlinux vm.

I would rather find a way to generate the required plugins even with a cross compiler, so i can keep my fast builds.

What would be the goal to have mister-headers with x86_64 plugins? I think any dkms compilation will happen inside chroot.