Move definition of split down a bit

MiSawa / xq

Pure rust implementation of jq

MIT License

318 stars 18 forks source link

Move definition of split down a bit #91

Closed itchyny closed 2 years ago

itchyny commented 2 years ago

I noticed that I placed between explode and implode, but I was to place down after implode (ref: #90). Also I think &*rhs is ok to be replaced by rhs but is that right?

MiSawa commented 2 years ago

Cool, thanks!

Also I think &*rhs is ok to be replaced by rhs but is that right?

Should be good as long as it compiles. I believe it was like that to get &String from Rc<String> or something, but now that we have &String it should be good.