search

MiSecurity / x-patrol

github泄露扫描系统
1.15k stars 303 forks source link

这段代码写的太迷幻了：） #7

Closed hiij3ck closed 6 years ago

hiij3ck commented 6 years ago 
func Search(rules []models.Rules) () {
    var wg sync.WaitGroup
    wg.Add(len(rules))
    client, token, err := GetGithubClient()
    if err == nil && token != "" {
        for _, rule := range rules {
            go func(rule models.Rules) {
                defer wg.Done()
//这个goroutine的意义在哪？？？？
            }(rule)

            SaveResult(client.SearchCode(rule.Pattern))
        }
        wg.Wait()
    }
}
netxfly commented 6 years ago

刚看了下，应该是修改代码时，把SaveResult放错位置了，多谢指出，已修复。

func Search(rules []models.Rules) () {
    var wg sync.WaitGroup
    wg.Add(len(rules))
    client, token, err := GetGithubClient()
    if err == nil && token != "" {
        for _, rule := range rules {
            go func(rule models.Rules) {
                defer wg.Done()
                SaveResult(client.SearchCode(rule.Pattern))
            }(rule)
        }
        wg.Wait()
    }
}