Open markmilman opened 9 years ago
We talked about it yesterday Ya mastul. There is a bug already opened.
Best, Ishay
Sent from my iPhone
On Sep 29, 2014, at 11:33, Mark Milman notifications@github.com wrote:
What happened to the negotiation changes? Why did you filter out all submitted changes?
Here the code from _agreement_history.html.erb
<% @agreement.events.each do |event| %> <tr> <% if event.name == "Change Submitted" %> <% else %> <td> <%= event.name %> </td> <td> <%= event.description.html_safe %> </td> <td> <%= l event.created_at, :format => :long %> </td> <td> <%= event.creator.name %> </td> </tr> <% end %> <% end %>
— Reply to this email directly or view it on GitHub.
I added a new button (changes) that opens a new modal (partial agreement_changes) Problem is that the "see more" link always show the first change - I can't find where you drew the table of changes (the see more) - can u help?
/app/views/agreements/agreement_diff/_diff_table.html.erb
AgrVersionDiffService to hold a ref to the event, to set an id in the view for the collapse :/sbcx/app/views/agreements/agreement_diff/_diff_table.html.erb
What happened to the negotiation changes? Why did you filter out all submitted changes?
Here the code from _agreement_history.html.erb