search

MiYa-Solutions / sbcx

0 stars 0 forks source link

Job Ext Id - add validation #741

Closed ishayyaari closed 9 years ago

ishayyaari commented 9 years ago

Request from RugWash: Previously used ext. id will not be able to used (should be unique id)

markmilman commented 9 years ago

It is already there, assuming they checked on the checkbox On Mar 18, 2015 1:40 PM, "ishayyaari" notifications@github.com wrote:

Assigned #741 https://github.com/MiYa-Solutions/sbcx/issues/741 to @markmilman https://github.com/markmilman.

— Reply to this email directly or view it on GitHub https://github.com/MiYa-Solutions/sbcx/issues/741#event-258423581.

ishayyaari commented 9 years ago

They want the system to show an error when the user is trying to enter an Ext. id that has been previously used

markmilman commented 9 years ago

So validate only if a ref is provided... right? On Mar 18, 2015 5:49 PM, "ishayyaari" notifications@github.com wrote:

They want the system to show an error when the user is trying to enter an Ext. id that has been previously used

— Reply to this email directly or view it on GitHub https://github.com/MiYa-Solutions/sbcx/issues/741#issuecomment-83197160.

ishayyaari commented 9 years ago

Yes, if the user enters id - make sure its unique

Best, Ishay

Sent from my iPhone

On Mar 18, 2015, at 18:11, Mark Milman notifications@github.com wrote:

So validate only if a ref is provided... right? On Mar 18, 2015 5:49 PM, "ishayyaari" notifications@github.com wrote:

They want the system to show an error when the user is trying to enter an Ext. id that has been previously used

— Reply to this email directly or view it on GitHub https://github.com/MiYa-Solutions/sbcx/issues/741#issuecomment-83197160.

— Reply to this email directly or view it on GitHub.

markmilman commented 9 years ago

Will run some tests and if all goes well will deploy to production on the weekend