search

MiamiOH / puppet-tcpwrappers

Puppet module for managing tcpwrappers with Augeas
GNU General Public License v3.0
1 stars 5 forks source link

Incorrect Documentation or bug? #4

Open furlongm opened 7 years ago

furlongm commented 7 years ago

Hi,

This works correctly:

tcpwrappers::allow { ['127.0.0.1', 'www.example.com'] }

but this does not:

  tcpwrappers::allow { sysadmins:
    daemon => 'ALL',
    client => ['127.0.0.1', 'www.example.com'];
  }

The second version gives the following output

# puppet agent -t
Info: Using configured environment 'production'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Function Call, normalize_tcpwrappers_client: argument must be a String at /etc/puppetlabs/code/environments/production/modules/tcpwrappers/manifests/entry.pp:37:14 at /etc/puppetlabs/code/environments/production/modules/tcpwrappers/manifests/allow.pp:9 on node ceph-n10.sy3.aptira.com
Warning: Not using cache on failed catalog
Error: Could not retrieve catalog; skipping run

The documentation suggests the above two are equivalent, so both should work?

matonb commented 6 years ago

It'll be the semicolon at the end of the client => line