Miaxos / sharded-thread

Sharding between threads
Apache License 2.0
7 stars 2 forks source link

Update continuous benchmarking with Bencher #16

Closed epompeii closed 9 months ago

epompeii commented 9 months ago

The cron schedule for the main branch been updated to once a day instead of once every hour. The benchmark results are still run 16 times. However, only the minimum result is stored using --fold. https://bencher.dev/docs/explanation/bencher-run/#--fold-fold Since every stored result gets compared against its Threshold, making this change will help reduce the number of false positives.

The permissions for the GitHub Token in pull requests has been limited in scope only to write on pull requests. The job itself has also been limited to only run on internal PRs. This is to prevent pwn requests. To handle PRs from forks, I can implement either of these in a follow up PR: https://bencher.dev/docs/how-to/github-actions/#pull-requests-from-forks The benchmark results are still run 2 times. However, only the minimum result is stored using --fold, just as we did with the main branch.