search

Mibew / mibew

Mibew Messenger - open-source live support application
https://mibew.org
Other
473 stars 204 forks source link

PHP7 compatability... #175

Closed J-Fricke closed 7 years ago

J-Fricke commented 8 years ago

The dependencies for the justblackbird/handlebars.php-helpers package are now out of date and cause fatal error in php7. I have not tested updating the version # yet, but making this ready for php7 might be as easy as updating that and the packages xamin/handlebars.php to greater versions in the composer.json file.

J-Fricke commented 8 years ago

I believe this solves the issue #176

faf commented 8 years ago

Thanks, @J-Fricke .

At the time we haven't tested Mibew with PHP7. Are you sure that this is the only compatibility issue?

otarza commented 8 years ago

@faf I can confirm that this is the only issue I experienced while installing Mibew on php7, I have manually refactored String to StringWrapper in justblackbird/handlebars.php-helpers and it worked.

Of course we need to update hadnlebars.php to version 0.10.3.

faf commented 8 years ago

Ok, great to hear that. Then we're waiting for complete PR. :)

otarza commented 8 years ago

Guys, problem here is that https://github.com/JustBlackBird/handlebars.php-helpers already fixed this issue in their newer versions, but Mibew Messenger doesn't support newer version of this library.

As a workaround solution I just created a patch for justblackbird/handlebars.php-helpers and added my patch to composer.json file, if you are happy with this solution you can use it, have a look at this gist: https://gist.github.com/otarza/68f946325dd077c501894f76c0bfa637

J-Fricke commented 8 years ago

@otarza Have you tried the composer version updates and String namespace -> Text namespace change listed in #176 ?

faf commented 8 years ago

Most probably, fixed by #176. If there will be no more bug reports, the issue will be closed in two weeks.

josemi-ca commented 7 years ago

It's been way over two weeks already, when will this be released on a new Mibew version? Thanks

faf commented 7 years ago

ok, the issue is closed.

as about new version of Mibew Messenger, maybe we'll release it before the end of the year.