search

Mibew / mibew

Mibew Messenger - open-source live support application
https://mibew.org
Other
473 stars 204 forks source link

PHP7 compatibility #176

Closed J-Fricke closed 8 years ago

J-Fricke commented 8 years ago

Makes ready for php7

JustBlackBird commented 8 years ago

It seems that you should manually set min version of xamin/handlebars.php too.

faf commented 8 years ago

@J-Fricke, just want to make it clear: once you set the version, we'll merge PR.

J-Fricke commented 8 years ago

@JustBlackBird What min value do we need to set for xamin/handlebars.php ?

@fat I did set the version of justblackbird/handlebars.php-helpers in my pull request, are you referring to the comment by @JustBlackBird ?

J-Fricke commented 8 years ago

Oh I was just reviewing the xamin/handlebars.php codebase and it looks like we need ~0.10.3

J-Fricke commented 8 years ago

I've pushed the min version for xamin/handlebars.php up as well. Let me know if there is anything else missing.

josemi-ca commented 8 years ago

@J-Fricke What are the exact steps required to make current mibew version installation work with PHP7? I've tried to apply the changes on "String" and have not being able to make it work.

Thanks!

J-Fricke commented 8 years ago

@JMCA2 have you implemented the version bumps and then upgraded your composer dependencies along with update the String namespace to Text as is listed here: https://github.com/Mibew/mibew/pull/176/files

faf commented 8 years ago

@J-Fricke Well, everything is fine. Thanks a lot! :)