search

Mibew / mibew

Mibew Messenger - open-source live support application
https://mibew.org
Other
473 stars 204 forks source link

Mibew generates absolute URLs even when they are not really needed. #187

Closed JustBlackBird closed 7 years ago

JustBlackBird commented 7 years ago

I've installed Mibew on a virtual machine with apache on port 80 (default HTTP port). Also I have nginx that is installed on another virtual machine on port 8080 and proxy all the requests to Mibew. I expect Mibew to generate only "Absolute Path" URLs (like /mibew/operator/), so I can serve all the pages with nginx without thinking about host/port inconsistency.

The problem is Mibew generates "Absolute URLs" (like http://localhost/mibew/operator) even when they are not really needed. In such case real Mibew's host/port are visible from the outside and are not served by nginx.

It seems that the current implementation of UrlGenerator is smart enough to generate "Absolute URLs" when it has to (even if the generator was asked about different type of URL). So why the developers decided to generate "Absolute URLs" manually?

Here is the list of problem places (it's not completed 'cause I'm still facing problems from time to time):

playcraft1 commented 7 years ago

This issue might be related to #188

faf commented 7 years ago

We need confirmation that #194 has fixed this.

faf commented 7 years ago

More than two months passed, no complaints were reported. Let's presume that the issue is fixed, but one could reopen in the future if the original problem is still persists.