search

Mibew / mibew

Mibew Messenger - open-source live support application
https://mibew.org
Other
473 stars 204 forks source link

Improve gulp file #195

Closed faf closed 7 years ago

faf commented 7 years ago

@snewell92 Go on. :)

faf commented 7 years ago

At the moment I'm very intrigued by the fact that the aforementioned code actually works.

snewell92 commented 7 years ago

Here is the PR that addresses the review comments, and removes the unused promises. If those were used for a reason, I'd like to know how and why. The other gulp tasks don't use them.

The other task functions also return a pipe(?) so maybe it should do that? Please add comments as you see fit to the PR.