Add support to pass through `--keep-going`

Mic92 / nix-fast-build

Combine the power of nix-eval-jobs with nix-output-monitor to speed-up your evaluation and building process.

MIT License

242 stars 12 forks source link

Add support to pass through `--keep-going` #66

Closed colemickens closed 4 months ago

colemickens commented 4 months ago

I use nix-fast-build to drive my CI. I'm finding that sometimes when my CI fails, I run the build remotely... and then see a bunch of successful new builds. I think this is because nix-fast-build is not sending --keep-going. It would be nice if nix-fast-build understood this and passed it to the remote builder or what not.

colemickens commented 4 months ago

Huh, well this is awkward. NFB passes --keep-going: https://github.com/Mic92/nix-fast-build/blob/cfff239d93716e92f6467f8953d8f8c12da1892a/nix_fast_build/__init__.py#L678

Clearly I have some other wrong assumption, based on what I think I'm seeing.

Anyway, thanks, and closing this.