bin/nixos-shell: use `nix run` to run; flake.nix: use `packages.<system>.default`

Mic92 / nixos-shell

Spawns lightweight nixos vms in a shell

MIT License

677 stars 39 forks source link

bin/nixos-shell: use `nix run` to run; flake.nix: use `packages.<system>.default` #76

Closed ShamrockLee closed 8 months ago

ShamrockLee commented 8 months ago

This PR is a collection of small refactoring.

bin/nixos-shell:
- Use nix run to run the code instead of current mktemp hack.
- Note that Nix 3.0 commands like nix run evaluates purely by default, contrary to Nix classic commands like nix-build.
flake.nix:
- Use packages.<system>.default instead of defaultPackages.<system>.
- Recurse with inp.self instead of rec.

Mic92 commented 8 months ago

We probably still need impure evaluation because getFlake needs it as well as those environment variables that it still uses (also those can be probably refactored out).

Mic92 commented 8 months ago

Thanks!

ShamrockLee commented 8 months ago

I didn't add --impure because the help message indicates that users can choose if they would like to add --impure or not.

BTW, why is -k added even if the help message lists --keep-going as an optional flag?

Mic92 commented 7 months ago

The --file flag already adds it --impure implicitly actually. Don't remember why I added --keep-going. Sometimes I like doing this for ci-related builds as it will try to build as much as possible so that on the next run it starts only with the failing derivations and it's dependencies. As such it won't abort working builds, which cuts down a bit of noise and avoids re-doing long-running builds.