Open davidak opened 3 years ago
tests.nixos-functions.nixos-test
is not what you expect. It is not a particular nixos test but a function that we should not try to build. Did you expect with this package a particular nixos service to be run?
I have seen that the PR adds a nixos test and
1 package blacklisted:
tests.nixos-functions.nixos-test
in the log, so my conclusion was that that is related to the added nixos test.
The "allow to build nixos tests" in the readme can be understood as it is an option to run nixos tests and it is described how to do so.
So my question is, would it make sense to run them automatically? I think that would make sense when you review and test a PR.
What do you think?
Yes. Feel free to implement that. However note that tests should be not evaluated with the other packages and build separately as they can consume a lot of memory. My recommendation is to retrieve the tests name from passthru.tests in nixpkgs_review/nix/evalAttrs.nix
and than build those tests after the normal build and before starting the nix-shell.
The features list includes "allow to build nixos tests", so i expect that a nixos test, that is added in a PR, get executed.
That seem not to be the case:
Or is it expected behavior that nixos tests get blacklisted and have to get enabled manually?
In that case, please add an explanation to the output and instructions how to run them. Maybe even interactive from within the nix-shell.
Running tests like described in the Readme works.
Thanks for providing this great tool!