search

Mic92 / nixpkgs-review

Review pull-requests on https://github.com/NixOS/nixpkgs
MIT License
375 stars 61 forks source link

Reproducible check #191

Open tomberek opened 3 years ago

tomberek commented 3 years ago

Propagate or allow a --check on a PR to check for reproducibility for packages changed during a pr/wip.

https://r13y.com

SuperSandro2000 commented 3 years ago

Does nixpkgs-review pr --build-args="--check" XXXXX work for your use case?

tomberek commented 3 years ago

ah, possibly --build-args="--option repeat 1 --option enforce-determinism true" seems to be working, but only if the specific packages have not been built already. --rebuild seems to only rebuild the "review-shell", not the dependent packages

GC'ing the packages is possible, but most convenient would be if --rebuild was passed along to each individual package being built.

SuperSandro2000 commented 3 years ago

Can we tell nix to rebuild the dependency chain one deep? Otherwise I think this would require bigger changes in nixpkgs-review.