search

Mic92 / nixpkgs-review

Review pull-requests on https://github.com/NixOS/nixpkgs
MIT License
367 stars 59 forks source link

Run evals in parallel #218

Open Atemu opened 2 years ago

Atemu commented 2 years ago

Compared to the rest of the runtime, the eval via nix-env takes the longest time when uncached.
It'd be nice if two checkouts could be made with two nix-env evals in parallel to speed this up.

This would also catch merge conflicts early; you currently have to wait through a lengthy eval before it's even attempted.

It might have to be disabled by default due to memory constraints (or based on available host memory) but 2x6GiB isn't too much to ask for nowadays.

Mic92 commented 2 years ago

That would also require to have both nixpkgs trees checked out at the same time. I could check if https://github.com/nix-community/nix-eval-jobs could improve things here as it also deals with memory consumption.