search

Mic92 / nixpkgs-review

Review pull-requests on https://github.com/NixOS/nixpkgs
MIT License
381 stars 63 forks source link

Allow the user to open a pure shell #248

Open tobiasBora opened 2 years ago

tobiasBora commented 2 years ago

In order to test if the environment is not causing some troubles, I tried to use the sandbox feature of nixpkgs-review. Unfortunately, it is not equivalent to nix-shell --pure as the environment variables are not cleared:

$ export AJJJ=abcd

$ nix-shell -p bubblewrap

$ nix run github:Mic92/nixpkgs-review?rev=b1ad5652da53ac4d531c27f557eab3bf0871f637#nixpkgs-review -- pr --sandbox https://github.com/NixOS/nixpkgs/pull/144708

$ echo $AJJJ
abcd

On the other side, nix-shell --pure provides clean environment:

$ nix-shell -p bubblewrap --pure

$ echo $AJJJ

Would it be possible to add a --pure functionality to nixpkgs-review?