Don't merge/rebase - Githubissues

Mic92 / nixpkgs-review

Review pull-requests on https://github.com/NixOS/nixpkgs

MIT License

381 stars 63 forks source link

Don't merge/rebase #250

Closed piegamesde closed 2 years ago

piegamesde commented 2 years ago

I often use nixpkgs-review during the development of a PR. In this, the feature that the PR is rebased or merged onto master is rather annoying:

It takes quite a lot of time, although iteration time is important to me
It makes things harder to develop, as master is a moving target (new error may appear over time, and results between review and my local checkout may differ)
It totally breaks when there are any merge conflicts. This is especially annoying since our new (21.11) release notes policy

Please add a flag so that I can skip that check and only build the packages as they are in the code.

SuperSandro2000 commented 2 years ago

You want to use nixpkgs-review rev, nixpkgs-review pr --checkout commit or nixpkgs-review wip.