search

Mic92 / nixpkgs-review

Review pull-requests on https://github.com/NixOS/nixpkgs
MIT License
381 stars 63 forks source link

Disable aliases by default #255

Closed jonringer closed 2 years ago

jonringer commented 2 years ago

Ofborg does a check with allowAliases = false;. So it's safe to assume that our evaluation shouldn't have to worry about them either.

 ofborg-eval-package-list-no-aliases — nix-env -qa --json --file . --arg config { allowAliases = false; }

related: https://github.com/Mic92/nixpkgs-review/pull/254

jonringer commented 2 years ago

This would be a cli breaking change. Not sure if you want to do the semver bump or not

SuperSandro2000 commented 2 years ago

This would be a cli breaking change. Not sure if you want to do the semver bump or not

We probably release it as 2.7.0 in a bit.