Mic92 / nixpkgs-review

Review pull-requests on https://github.com/NixOS/nixpkgs
MIT License
356 stars 59 forks source link

Doesn't see anything to be built #274

Closed winterqt closed 2 years ago

winterqt commented 2 years ago

nixpkgs-review v2.7.0:

$ nixpkgs-review pr 180271
$ git -c fetch.prune=false fetch --no-tags --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/180271/head:refs/nixpkgs-review/1
remote: Enumerating objects: 9, done.
remote: Counting objects: 100% (9/9), done.
remote: Compressing objects: 100% (8/8), done.
remote: Total 9 (delta 0), reused 4 (delta 0), pack-reused 0
Unpacking objects: 100% (9/9), 228.22 KiB | 2.30 MiB/s, done.
From https://github.com/NixOS/nixpkgs
 + 273dce6c32f...d31f0743f07 refs/pull/180271/head -> refs/nixpkgs-review/1  (forced update)
$ git worktree add /Users/winter/.cache/nixpkgs-review/pr-180271/nixpkgs 23ee5ac46ad942208b82f3631d891cdb60bb8409
Preparing worktree (detached HEAD 23ee5ac46ad)
Updating files: 100% (30982/30982), done.
HEAD is now at 23ee5ac46ad vscode-extensions.piousdeer.adwaita-theme: init at 1.0.7
$ git merge --no-commit --no-ff d31f0743f07a884db41e29db738f33350b2f1d98
Automatic merge went well; stopped before committing as requested
Nothing to be built.

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/180271

$ /nix/store/9s055bnn4l671f7vlsyaifsbr5z64jij-nix-2.9.1/bin/nix-shell /Users/winter/.cache/nixpkgs-review/pr-180271/shell.nix

This is on a PR which adds a new package (NixOS/nixpkgs#180271), and I've also seen it happen on a PR that updates an existing package (NixOS/nixpkgs#180227).

winterqt commented 2 years ago

Looks like it's OfBorg support that's causing it not to build.