Open Atemu opened 2 years ago
I have not found a way to get indirect dependencies cheaply from the nix-env query output so far. I would like to have the dependency tree for many reason though.
An idea I had on this:
(tryEval (toString package).success
It's not a perfect solution but a package that is depended upon by other modified packages should usually exist in the list of modified packages too.
Would you accept a on this @Mic92?
BTW regarding the dependency tree, nix-output-monitor has logic in it that somehow parses the dependency tree and figures out how to print a dependency... Perhaps some ideas could be brought from there. It'd be also useful information to put in the result.md
- showing which dependent packages failed due to a dependency failing, is very useful information.
Would you accept a on this @Mic92?
Marking packages as broken would be fine. Our report.md would get skewed a bit, but this is the ase anyway when only building a subset.
BTW regarding the dependency tree, nix-output-monitor has logic in it that somehow parses the dependency tree and figures out how to print a dependency... Perhaps some ideas could be brought from there. It'd be also useful information to put in the
result.md
- showing which dependent packages failed due to a dependency failing, is very useful information.
I parses the derivation in question, this would need to be done recursively.
However,
nixpkgs-review
still tries to build tensorflow and tengine eventhough I explicitly declared to skip them:What I suspect is happening is that the skips only apply to direct dependencies rather than transitive dependencies. Even if this is intended, it breaks the principle of least surprise and should at least be documented in the help screen.
As a reviewer, I need the ability to completely disallow building certain packages to keep build times under control.