search

Mic92 / nixpkgs-review

Review pull-requests on https://github.com/NixOS/nixpkgs
MIT License
356 stars 59 forks source link

onto option for --checkout #287

Open figsoda opened 1 year ago

figsoda commented 1 year ago

It would be nice to be able to use git rebase --onto for the checkout options, this will make it easier to review prs targetting staging

Mic92 commented 1 year ago

From nixpkgs-review point of view how is a merge different from a rebase? I do not understand the issue here yet.

figsoda commented 1 year ago

With rebase --onto we can apply a staging pr to master so we don't have to rebuild the world to review a staging pr. I'm not aware of an alternative in nixpkgs-review currently

Mic92 commented 1 year ago

Ah. I see this makes now sense to me.