Mic92 / nixpkgs-review

Review pull-requests on https://github.com/NixOS/nixpkgs
MIT License
380 stars 63 forks source link

disable ifd by default #288

Closed figsoda closed 1 year ago

figsoda commented 1 year ago

also added --allow-ifd/--allow-import-from-derivation to renable ifd

figsoda commented 1 year ago

tests got rate limited :thinking:

Mic92 commented 1 year ago

Do we use the github token from the github actions runner there?

This is what nixpkgs-review would use:

  token = os.environ.get("GITHUB_OAUTH_TOKEN", os.environ.get("GITHUB_TOKEN"))
Mic92 commented 1 year ago

github actions exposes this via ${{ secrets.GITHUB_TOKEN }}

Mic92 commented 1 year ago

addressed in https://github.com/Mic92/nixpkgs-review/pull/289

Mic92 commented 1 year ago

bors merge

bors[bot] commented 1 year ago

Canceled.

Mic92 commented 1 year ago

bors merge

bors[bot] commented 1 year ago

Build failed: