Mic92 / nixpkgs-review

Review pull-requests on https://github.com/NixOS/nixpkgs
MIT License
356 stars 59 forks source link

disallow url literals by default #293

Closed figsoda closed 1 year ago

figsoda commented 1 year ago

this is the default behavior for ofborg and hydra: https://github.com/NixOS/ofborg/pull/628

also adds --allow-url-literals

SuperSandro2000 commented 1 year ago

What speaks against settings this globally in nix.conf?

figsoda commented 1 year ago

That would require the user to do it, and users don't have to follow nixpkgs conventions for all of their nix projects

SuperSandro2000 commented 1 year ago

true but ofborg is also checking it now. Not sure if we really need it but it is a nice addition.

figsoda commented 1 year ago

url literals are probably just supported for the sake of backward compatibility, I'm not sure if there is anything else nixpkgs-review can do to change that

Mic92 commented 1 year ago

bors merge

bors[bot] commented 1 year ago

Build succeeded: