search

Mic92 / nixpkgs-review

Review pull-requests on https://github.com/NixOS/nixpkgs
MIT License
353 stars 59 forks source link

Printing the result comment to stdout instead of posting it #311

Closed ruuda closed 1 year ago

ruuda commented 1 year ago

There is nixpkgs-review post-result, but it requires a GitHub access token, and I’m not really comfortable giving nixpkgs-review access to one. If nixpkgs-review could print the comment that it would post, I would happily paste it into the comment box in my browser and post it manually.

figsoda commented 1 year ago

The results are stored in report.md if that helps, but it does make some sense to have print-result command and --print-result flag

Mic92 commented 1 year ago

I think we would only need --print-result-md flag as we the other command could be also just cat report.md instead.

ruuda commented 1 year ago

The results are stored in report.md if that helps

This does help, I did not notice that file before, thanks!

figsoda commented 1 year ago

opened #312 to implement --print-result, I named it without -md to be more consistent with --post-result