search

Mic92 / nixpkgs-review

Review pull-requests on https://github.com/NixOS/nixpkgs
MIT License
353 stars 59 forks source link

fix gist url calculation #322

Closed figsoda closed 1 year ago

figsoda commented 1 year ago

closes #321

There was likely an update in github's gist api that added the username to the returned url, which makes the previous logic not work with the new ofborg gist urls

Mic92 commented 1 year ago

bors merge

Mic92 commented 1 year ago

will do a release in a bit.

bors[bot] commented 1 year ago

Build succeeded:

Mic92 commented 1 year ago

https://github.com/Mic92/nixpkgs-review/releases/tag/2.9.0

Mic92 commented 1 year ago

@figsoda can you bump it in nixpkgs?

Mic92 commented 1 year ago

needs a backport.

figsoda commented 1 year ago

https://github.com/NixOS/nixpkgs/pull/222211

working on a backport rn

figsoda commented 1 year ago

https://github.com/NixOS/nixpkgs/pull/222214