search

Mic92 / nixpkgs-review

Review pull-requests on https://github.com/NixOS/nixpkgs
MIT License
353 stars 59 forks source link

`--nom` is not recognized #323

Closed NobbZ closed 1 year ago

NobbZ commented 1 year ago

The 2.9 --nom flag is not recognized:

$ nix run github:Mic92/nixpkgs-review/2.9.0 -- --nom pr 222132
usage: /nix/store/kn6410765k8j2pdm5wpzcgh8ap7jr7r6-nixpkgs-review/bin/nixpkgs-review [-h] {post-result,approve,comments,merge,pr,rev,wip} ...
/nix/store/kn6410765k8j2pdm5wpzcgh8ap7jr7r6-nixpkgs-review/bin/nixpkgs-review: error: unrecognized arguments: --nom

Moving it after pr 222132 does not change anything.

figsoda commented 1 year ago

The title of the pull request, and by extension the changelog is inaccurate. nixpkgs-review should automatically use nom if it is in PATH, and the flag that we ended up adding is --build-graph nix|nom

figsoda commented 1 year ago

Edited the release log, is this good to close?

Mic92 commented 1 year ago

Looks good to me.