Mic92 / nixpkgs-review

Review pull-requests on https://github.com/NixOS/nixpkgs
MIT License
350 stars 59 forks source link

Suggestion: add derivation logs in the summary #368

Open lucasew opened 8 months ago

lucasew commented 8 months ago

I, at least, have the habit of when a a PR settles I run this to check if that works on my machine is not happening but sometimes the build fails and it only posts if a package is failed or successfully built without any kind of logs.

My suggestion is to add the logs using summary/details so the logs are hidden by default but still acessible when the summary is posted.

But there are some concerns:

The link with related information about this summary/details thing: https://gist.github.com/scmx/eca72d44afee0113ceb0349dd54a84a2

Mic92 commented 8 months ago

I am bit concerned that we abuse gist as a ci pastebin service. Unlike other pastebins they store logs forever. Just now it's only ofborg itself but this would multiple the number of logs done by individuals. What I could imagine is to store the last 25 lines per failed build in a summary and have a limit how many failed builds to include in this report.

lucasew commented 8 months ago

Seems fair