search

Mic92 / nixpkgs-review

Review pull-requests on https://github.com/NixOS/nixpkgs
MIT License
379 stars 63 forks source link

add pylint configuration #371

Closed Artturin closed 11 months ago

Artturin commented 11 months ago

but not tests yet

Artturin commented 11 months ago

Will fix more lints in a separate PR

figsoda commented 11 months ago

Ruff seems to support some pylint lints under PL, since we are already using ruff, can we use ruff instead? Adding "PL" to tools.ruff.select might be sufficient

Mic92 commented 11 months ago

Here is a feature comparison: https://github.com/astral-sh/ruff/blob/d31a700f773b97b265109b63bbeb0ef994f63a3b/README.md#how-does-ruff-compare-to-pylint

Mic92 commented 11 months ago

I guess it doesn't hurt.. checking should be still fast enough

Mic92 commented 11 months ago

@mergify queue

mergify[bot] commented 11 months ago

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at *c20b63f75a66919f1c52d2cf498d7c101ac31978*