search

Mic92 / nixpkgs-review

Review pull-requests on https://github.com/NixOS/nixpkgs
MIT License
379 stars 63 forks source link

Make the `review-shell` purer #373

Open Artturin opened 11 months ago

Artturin commented 11 months ago

The only purpose of this env (I assume) is to add the binaries to the PATH.

The benefit of making it purer is that unwrapped programs missing dependencies may fail.

As a added benefit this dramatically reduces the collision warnings from buildEnv

warning: collision between '/nix/store/82icynaidvzyic2g349cqi4p9a5d4aa2-vimplugin-ai.vim-2023-10-03/doc/tags' and '/nix/store/qc4bdwi6zhk4r1vzbcxrnwrrjnm33a6g-vimplugin-CheckAttach-2019-05-08/doc/tags'

Closes https://github.com/Mic92/nixpkgs-review/issues/370

Mic92 commented 9 months ago

@mergify queue

mergify[bot] commented 9 months ago

queue

🛑 The pull request has been removed from the queue default

Unexpected queue change: the updated pull request #373 has been manually updated. You can take a look at `Queue: Embarked in merge queue` check runs for more details. In case of a failure due to a flaky test, you should first retrigger the CI. Then, re-embark the pull request into the merge queue by posting the comment `@mergifyio refresh` on the pull request.
Mic92 commented 9 months ago

@mergifyio refresh

mergify[bot] commented 9 months ago

refresh

✅ Pull request refreshed

Mic92 commented 9 months ago

@mergify queue

mergify[bot] commented 9 months ago

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks. You can take a look at `Queue: Embarked in merge queue` check runs for more details. In case of a failure due to a flaky test, you should first retrigger the CI. Then, re-embark the pull request into the merge queue by posting the comment `@mergifyio refresh` on the pull request.