search

Mic92 / nixpkgs-review

Review pull-requests on https://github.com/NixOS/nixpkgs
MIT License
350 stars 59 forks source link

nix: make review-shell.nix code static #382

Closed Atemu closed 6 months ago

Atemu commented 6 months ago

Previously, the whole shell.nix was created at runtime using string substitution and other crimes that made it hard to work on the expression itself.

This patch turns the string substitutions into Nix function arguments to an otherwise static Nix expression and only generates the list of attrs to be built dynamically.

Mic92 commented 6 months ago

@mergify queue

mergify[bot] commented 6 months ago

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at *d75803365aac84b0d5ce95a1d2671fd82c674008*
Atemu commented 6 months ago

Thanks!