Mic92 / nixpkgs-review

Review pull-requests on https://github.com/NixOS/nixpkgs
MIT License
379 stars 63 forks source link

nixpkgs-review shell breaks pr 277935 #383

Closed quantenzitrone closed 9 months ago

quantenzitrone commented 9 months ago

https://github.com/NixOS/nixpkgs/pull/277935 I don't really know what is going on and it is probably also not nixpkgs-review fault, but: this crashes:

nixpkgs-review pr 277935
gprename

and these all do not:

nixpkgs-review pr 277935 --sandbox
gprename
nix build github:quantenzitrone/nixpkgs/gprename#gprename
result/bin/gprename
nix build github:quantenzitrone/nixpkgs/gprename#gprename
env --ignore-environment DISPLAY=$DISPLAY HOME=$HOME result/bin/gprename

so there must be something in the non-sandboxed nixpkgs-review shell that crashes gprename...

SuperSandro2000 commented 9 months ago

Can you start the program with strace?

quantenzitrone commented 9 months ago

I found out the deciding factor: the folder. Anywhere in ~/.cache it crashes, anywhere else not. The strace output is huge and basically dumps my whole home folder structure into stderr. I don't want to post this publicly on GitHub, but I could send it to you privately if you want, but don't think this is a nixpkgs-review issue, since any folder in ~/.cache is affected.

quantenzitrone commented 9 months ago

https://sourceforge.net/p/gprename/bugs/28/