search

Mic92 / nixpkgs-review

Review pull-requests on https://github.com/NixOS/nixpkgs
MIT License
350 stars 59 forks source link

argcomplete: fix auto-generated shell-completions in postInstall #391

Closed SebTM closed 3 months ago

SebTM commented 3 months ago

Result after this change (zsh, but tested in bash and also makes them work but less nice but also unconfigured bash compared to personal zsh-setup): Screenshot from 2024-03-16 21-55-10 Screenshot from 2024-03-16 21-55-21

I wen the wrong way first and tried to setup/make argcomplete global-setup work with NixOS/wrappers by resolving the last line and redirecting the resolution but later figured out that's not needed.

I looked through nixpkgs and only found one other package using the full path (https://github.com/search?q=repo%3ANixOS%2Fnixpkgs+register-python-argcomplete+%24out&type=code) and enabling _ARC_DEBUG made me realize the registered completion does not trigger as it never (except you copy the full path to nix-store) matches.

If this is accepted I can also provide a nixpkgs-pr with reference to here ✌🏻

Mic92 commented 3 months ago

@mergify queue

mergify[bot] commented 3 months ago

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at *f2c5167b814db7c883e4bd24c62b726171c2a675*