Mic92 / nixpkgs-review

Review pull-requests on https://github.com/NixOS/nixpkgs
MIT License
379 stars 63 forks source link

Reports for PR runs should contain commit hashes #395

Open mschwaig opened 6 months ago

mschwaig commented 6 months ago

I often read the results of a nixpkgs-revew run from ~/.cache/nixpkgs-review/pr-[pr-number].

One of the files in there, probably the report itself, should contain hashes of the commits in question, so that it's clear, without having to rely on my own memory, what exact version of the package set was actually built.

The relevant commit hashes are:

Mic92 commented 6 months ago

Sounds like a good idea.