search

Mic92 / nixpkgs-review

Review pull-requests on https://github.com/NixOS/nixpkgs
MIT License
409 stars 66 forks source link

Pass/fail reports are not visually distinct enough to tell apart at a glance #404

Closed Atemu closed 2 months ago

Atemu commented 5 months ago

In https://github.com/NixOS/nixpkgs/pull/318912 @siraben posted a nixpkgs-review but nobody noticed that the nixpkgs-review text said that the build has failed. Luckily, it was just a fluke but this shouldn't happen. A failure should be obvious and not easily confused with a pass.

To improve nixpkgs-review in this regard, I propose usage of obviously distinct visual patterns for pass and failed such as emboldening failed or adding an emoji.

I don't typically use them but I think Emoji could really shine here as they feature bright obvious colours and distinct shapes.

Does that sound good?

Mic92 commented 5 months ago

Sure. Let's add some :fire: or something else: https://gist.github.com/rxaviers/7360908