search

Mic92 / nixpkgs-review

Review pull-requests on https://github.com/NixOS/nixpkgs
MIT License
410 stars 66 forks source link

Running `nixpkgs-review pr 337953` takes indefinitely long #413

Closed rrcomtech closed 2 months ago

rrcomtech commented 3 months ago

I'm running 

nixpkgs-review pr 337953

and get 

$ git -c fetch.prune=false fetch --no-tags --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/337953/head:refs/nixpkgs-review/1

After that, nothing happens. I assume that this is due to the size of nixpkgs. So is there a way I can still use nixpkgs-review?

Mic92 commented 3 months ago

Mhm. Shouldn't take too long. Can you run git fetch from github normally? Sometimes github just has a bad day. Make sure to have everything green on https://status.github.com

rrcomtech commented 3 months ago

Yes, git fetch works just fine and completes within a couple of seconds. What are the requirements on the nixpkgs dir that I'm in? I don't have a complete clone of the nixpkgs repo, but a repo containing only the branch that I want to review.

Mic92 commented 3 months ago

Ah. maybe git doesn't find the matching ref and does some really slow search. I think it's better to have the full history of master or staging depending on the PR.

rrcomtech commented 2 months ago

But cloning the full master might be really hard to do? Even the wiki suggests running git clone <nixpkgs> --depth 1. So you wouldn't have the whole history. At least cloning on my machine fails when not specifying --depth 1.

Mic92 commented 2 months ago

Don't know how to fix this. Not sure why you cannot just do a full clone of nixpkgs. If you run already in performance bottlenecks with this, your computer might be not powerful enough to run other nix operations.

rrcomtech commented 2 months ago

Usually, cloning such a big project does not work well on smaller machines. I guess I got it working now, when using a bigger internet connection.