search

Mic92 / nixpkgs-review

Review pull-requests on https://github.com/NixOS/nixpkgs
MIT License
410 stars 66 forks source link

chunked local evaluation #429

Open GaetanLepage opened 1 week ago

GaetanLepage commented 1 week ago

See https://github.com/NixOS/nixpkgs/pull/356023

infinisil commented 1 week ago

Also check out https://github.com/tweag/nixpkgs/tree/gha-eval/ci/eval#nixpkgs-ci-evaluation, that's the latest state of the above-linked PR

Mic92 commented 1 week ago

Eval got merged. We can also start using the json.

JohnRTitor commented 1 week ago

I would add that instead of fetching @ofborg's evaluation result, if available it should fetch our new CI evaluator. https://github.com/NixOS/nixpkgs/actions/runs/11947073470/job/33302502332?pr=357763

Mic92 commented 1 week ago

I would add that instead of fetching @ofborg's evaluation result, if available it should fetch our new CI evaluator. https://github.com/NixOS/nixpkgs/actions/runs/11947073470/job/33302502332?pr=357763

So much todo and so little time :). If you want to take a step at it, I wouldn't mind. We can even check for both ofborg and the github one so it also works for older PRs that haven't been updated. However we don't have that json for master yet.