Mic92 / python-mpd2

Python library which provides a client interface for the Music Player Daemon.
GNU Lesser General Public License v3.0
352 stars 119 forks source link

async can't read binary data #138

Closed chrysn closed 3 years ago

chrysn commented 3 years ago

Trying albumart() on async fails because _execute_binary is not implemented in async.

Adding it is not just as easy as it sounds because of how the async version is implemented (that is, by reading all lines and dispatching them to the current command; the 'reading the lines' part is what causes the trouble).

As due to the recently increased minimum version a few new idioms have become usable (and the async ecosystem has generally evolved in the last years), I consider rewriting a few parts around this in a way that would trivially solve the binary-data issue.