search

Mic92 / ssh-to-pgp

Convert SSH RSA keys to GPG keys
MIT License
22 stars 4 forks source link

Invalid key generated #12

Closed ettom closed 1 year ago

ettom commented 2 years ago

I think I found a bug, introduced in ff31dcba71ca73ea60e33ac67f85ea48d5f2ac61.

Output before that commit:

./ssh-to-pgp -i test-assets/id_rsa
-----BEGIN PGP PUBLIC KEY BLOCK-----

xsDNBAAAAAABDADSeS6SEputIOi2mQhLeIEJnMAink+KcUv38HnaLak3nnLmUsYJ
nXYB5KZGxaxVtIjr59J8TndmwniZ+wc0rql6Dkif9CsTXgAjxrPiknZNQ7JQbgWU
r0pk4jx/K3zLD6i/XAS8QWySNJmY5aJWySbF/K687kUMJ5ql0BX4Tt0RiWL4pIwz
ZZlLzH4rRySy4z1kbiuOZf8htVRtlGoDGqGViJRpuybSKrmXbevRI7aWjiml2BVT
MktPekAPx+MA3t/8EM/uJxtWp7g3BsneHQdKIjR0WEKAITTmuDLEEtIXXEUbgBW0
WjbD62nRft/A6/iyWykPJmkLA4WnSLS03caeUxCKoEthZ1xfBPCRNw7xbysQF8CH
Jz8cAMjZGgBGlOin8EKDhmlma6FZ94cAB5Tr4G3R0h4ky77bPk2/6vvZtyU/AFnD
P2HfGaRCDNF+Q7+fR9YmKwcW/vCa2ItIEXgMmBjS+yl0p+4fVaY6Q7bCTbrd6znb
6gTGo7nD9Kj/CGUAEQEAAc0pcm9vdCAoSW1wb3J0ZWQgZnJvbSBTU0gpIDxyb290
QGxvY2FsaG9zdD7CwOIEEwEIABYFAgAAAAAJENlvbolIGMelAhsPAhkBAADdzgwA
BZ7vG2IjikqP/a9t1Ian4M58/zWIhM2z94xPvazP29J0OQ1x500G3fBgUhu6oOoZ
6qPxoyO/GKAbmDUocahbckyBmbbYFBYN+HjzwVnhpRPS0xOvW4b/tEmZIgqDaHPH
Y+bHS9r9znAhDQnP2YyAnB7VMcqPtp+X+28MR9cgTN6JdTBeJOHptRQRPAvv6I4m
2Hc9HnwyFN8jM1bcEDKasO+5YVX+0nniSJpk92h4JgyPe9xB7zdyXHAh5yLlXRVN
lGg+P51qIpFcNvhMiH2M8iRPj4NPSygpKq/S0Dxq2txU1GIZQWs6nSSX07UWoU9l
vkjUuv6IXAbRjQ5wz45w8AzQ92vQ3RdKOMTi0mIUb/0DNChMl/F39glNOjVCJ2p9
XryXibU0ClSg7fo7Irb5nn9VyGAH4qfMsu4jLpIvNaB6Ygt9dbq7LvPIe0PxPJ1B
pwy8JHtfl3C/J9AjwXf4haNt5FZJsQwd5KKacNsgczSmirdaebwgE9BQ5RUeW7I8
=xwBn
-----END PGP PUBLIC KEY BLOCK-----82ddc034d5ded2524f701114d96f6e894818c7a5

Output after:

./ssh-to-pgp -i test-assets/id_rsa
-----BEGIN PGP PUBLIC KEY BLOCK-----

xsDNBAAAAAABDADSeS6SEputIOi2mQhLeIEJnMAink+KcUv38HnaLak3nnLmUsYJ
nXYB5KZGxaxVtIjr59J8TndmwniZ+wc0rql6Dkif9CsTXgAjxrPiknZNQ7JQbgWU
r0pk4jx/K3zLD6i/XAS8QWySNJmY5aJWySbF/K687kUMJ5ql0BX4Tt0RiWL4pIwz
ZZlLzH4rRySy4z1kbiuOZf8htVRtlGoDGqGViJRpuybSKrmXbevRI7aWjiml2BVT
MktPekAPx+MA3t/8EM/uJxtWp7g3BsneHQdKIjR0WEKAITTmuDLEEtIXXEUbgBW0
WjbD62nRft/A6/iyWykPJmkLA4WnSLS03caeUxCKoEthZ1xfBPCRNw7xbysQF8CH
Jz8cAMjZGgBGlOin8EKDhmlma6FZ94cAB5Tr4G3R0h4ky77bPk2/6vvZtyU/AFnD
P2HfGaRCDNF+Q7+fR9YmKwcW/vCa2ItIEXgMmBjS+yl0p+4fVaY6Q7bCTbrd6znb
6gTGo7nD9Kj/CGUAEQEAAc0pcm9vdCAoSW1wb3J0ZWQgZnJvbSBTU0gpIDxyb290
QGxvY2FsaG9zdD4=
=uf61
-----END PGP PUBLIC KEY BLOCK-----82ddc034d5ded2524f701114d96f6e894818c7a5

Importing the latter key with gpg fails:

82ddc034d5ded2524f701114d96f6e894818c7a5
gpg: key 0xD96F6E894818C7A5: no valid user IDs
gpg: this may be caused by a missing self-signature
gpg: Total number processed: 1
gpg:           w/o user IDs: 1
Mic92 commented 1 year ago

hopefully we no longer have this issue because we switched away from this fork of the crypto library: https://github.com/Mic92/ssh-to-pgp/blob/main/go.mod