search

MicBosi / VisualizationLibrary

Visualization Library is a C++ middleware for high-performance 2D and 3D graphics applications based on OpenGL 1.x-4.x supporting Windows, Linux and Mac OS X.
http://VisualizationLibrary.org
Other
342 stars 96 forks source link

Conflict with ESilhouetteMode when both files are used #178

Closed Christophe-ABEL closed 3 years ago

Christophe-ABEL commented 4 years ago

Hello, I found this problem when i tried to upgrade my VL version to 2.0

ESilhouetteMode Enum is declared both in Extrusion.hpp and Extrusions.hpp

FabienMathieu commented 4 years ago

Hi, Long time I haven't worked on it, but if I remember well, Extrusions was designed to generalize the extrusions with multiple closed outlines. That has to be confirmed by the maintainer, but maybe the original Extrusion file and class could just be removed.

Cheers

Christophe-ABEL commented 4 years ago

Hi Fabien !

Happy to have some news and hope everything’s well for you and your family.

Yes it was designed for that.

I agree, except to keep compatibility with old version, it could be possible to remove the old version.

In any case there is no problem to keep both file or not.

Regards Christophe ABEL

MicBosi commented 3 years ago

Hi @Christophe-ABEL and @FabienMathieu, thanks for reporting this. Could the typedef enum { SilhouetteClosed, SilhouetteOpen } ESilhouetteMode; definition be moved to the vlCore/vlnamespace.hpp file? Thanks!

MicBosi commented 3 years ago

Should be fixed now. https://github.com/MicBosi/VisualizationLibrary/commit/72dfb50d2ce5124cffb6e4d355c02a06331bfdae