search

MicBosi / VisualizationLibrary

Visualization Library is a C++ middleware for high-performance 2D and 3D graphics applications based on OpenGL 1.x-4.x supporting Windows, Linux and Mac OS X.
http://VisualizationLibrary.org
Other
342 stars 96 forks source link

New template constructors for Vector2, Vector3, and Vector4 cause build error when compiled with g++ 7.5.0 #194

Closed deadmorous closed 3 years ago

deadmorous commented 3 years ago

Hi, I've been using VL version v2.0-β2, and now tried to switch to the new version 2.1.

The new version does not build with g++ 7.5.0. The reason is the new constructors in Vector2, Vector3, and Vector4, those that specialize the templated constructor. The error messages are like

VisualizationLibrary/src/vlCore/Vector2.hpp:113:14: error: explicit specialization in non-namespace scope ‘class vl::Vector2<T_Scalar>’ Removing template<> seems to solve this problem, but I didn't try newer compiles.

Regards, Stepan Orlov

FabienMathieu commented 3 years ago

Hi,

I noticed the same thing. I added an PR some days ago, waiting for it to be accepted.

Regards

Fabien MATHIEU

deadmorous commented 3 years ago

Ok, found your PR. Let's then wait for it to get merged.

MicBosi commented 3 years ago

This should be fixed now. https://github.com/MicBosi/VisualizationLibrary/commit/e7270b68cd8fd8aa1d14893169d9527e4ae076a8