search

MicahWW / Python-Games

2 stars 0 forks source link

Create Color Attribute #31

Closed codyswanner closed 1 year ago

codyswanner commented 1 year ago

https://github.com/MicahWW/Python-Games/blob/9f493394cfc8efb83b29a81ac409638069e178b4/TicTacToe.py#L271

I like parts of this, like the fact that the background is left neutral instead of black, and I agree that adding color to the numbers does address the readability issue. I would still like to have the player icons/symbols in color as well, and I think the way it's set up in branch "adding_color" with class attributes is a cool way to do that for the same customization reasons behind removing references to "X" and "O" in the code -- the icons and colors can be easily customized by changing those centralized attributes.

I'm also applying that reasoning to this Issue -- if we make a class attribute for neutral/number color, then we can easily customize the board colors and also avoid hard-to-read ANSI color sequences in our functions.

codyswanner commented 1 year ago

This was resolved in 820d6dd, we assigned variables inside displayBoard to handle colors.