Micalobia / Full-Slabs

Adds vertical and mixed slabs to Minecraft
GNU General Public License v3.0
8 stars 2 forks source link

Vertical sabs do not work with Mo Glass #75

Closed zaide-chris closed 2 years ago

zaide-chris commented 2 years ago

It seams like Mo Glass generates horizontal glass slab textures then Full slab uses them for the vertical slabs. Full-Slabs may need to generate vertical slab glass textures to work fully with Mo Glass.

Micalobia commented 2 years ago

So Mo' Glass is something that needs configured, it can work In your config folder, in full_slabs.json, just add these blocks to the tiltableSlabs section:

"tiltableSlabs": [
    "minecraft:smooth_stone_slab",
    "mo_glass:glass_slab",
    "mo_glass:white_stained_glass_slab",
    "mo_glass:orange_stained_glass_slab",
    "mo_glass:magenta_stained_glass_slab",
    "mo_glass:light_blue_stained_glass_slab",
    "mo_glass:yellow_stained_glass_slab",
    "mo_glass:lime_stained_glass_slab",
    "mo_glass:pink_stained_glass_slab",
    "mo_glass:gray_stained_glass_slab",
    "mo_glass:light_gray_stained_glass_slab",
    "mo_glass:cyan_stained_glass_slab",
    "mo_glass:purple_stained_glass_slab",
    "mo_glass:blue_stained_glass_slab",
    "mo_glass:brown_stained_glass_slab",
    "mo_glass:green_stained_glass_slab",
    "mo_glass:red_stained_glass_slab",
    "mo_glass:black_stained_glass_slab"
  ]
Micalobia commented 2 years ago

Basically everything in that list will actually rotate the texture when making it go vertical, in vanilla Smooth Stone Slabs are the only one that need it.

RotokEralil commented 2 years ago

This works for the most part! but there are glass slab combos that seem to still glitch A Vertical slab in the vertical back space, with a vertical slab in the vertical right space. This does not cause a problem in the vertical left space. The texture on the top of the vertical back space slab, and the back of the veritcal right space slabs are missing. There are more combos that make issues but my brain hurts trying to describe the associate positioning's sorry lol, See attached pics

2022-01-07_19 31 35 2022-01-07_19 31 30 2022-01-07_19 32 21 2022-01-07_19 31 42

RotokEralil commented 2 years ago

2022-01-07_19 44 59

Micalobia commented 2 years ago

Oh that's neat, that's gonna be a tough one to patch Will make a separate issue for it, since it's technically a different problem caused by the same mod