search

MichDe / wordpress-geo-mashup

Automatically exported from code.google.com/p/wordpress-geo-mashup
1 stars 0 forks source link

Remove multiple marker selection behavior from the location editor #704

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. A user clicks on the location editor map (rather than drags the pin)
2.
3.

What is the expected output? What do you see instead?
Expect to see one pin where the user clicks. 
Instead we get two pins, a green pin where we clicked and a second red pin 
appears many miles from the clicked point (see attached example). A big problem 
for websites that allow users to place pins i.e. have implemented the 
location-editor map in a front end form.

Solution:
Move the if statement "if ( !selected_marker ) {"  in location-editor.js line 
991 up to encompass the preceding four lines of code (see attached).

Original issue reported on code.google.com by someoneg...@gmail.com on 28 Nov 2014 at 8:08

Attachments:

GoogleCodeExporter commented 9 years ago 
The actual intended behavior was to allow you to click in the vicinity of a 
location, then be able to leave the clicked location selected or choose from 
nearby named locations. At some point we stopped displaying more than one 
search result in most cases, which people seem to be okay with.

What's really needed to make sure there are no use cases left where one of many 
markers needs to be selected, and if so clean out all the unnecessary code that 
handled that. If we get rid of Google v2 code as well, we should end up with a 
nicely simplified editor.

Original comment by dylankk...@gmail.com on 16 Dec 2014 at 5:22