Open VahidN opened 5 years ago
It seems these don't have feature parity and could break if you upgraded to a new version of this library using System.Text.Json (Newtonsoft seems to handle your types better according to Microsoft) : https://docs.microsoft.com/en-us/dotnet/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.
With this consideration would you still desire this feature as the default, or as a separate option that makes the change more obvious to the user (e.g. a SEPARATE json serializer)?
Started to do this, but the different handling of JSON is scaring me too much [things like Newtonsoft allows comments in JSON but the new library does not by default].
I'd ship it as a completely separate serializer, which could be implemented within this library or externally to be promoted to first-class at a later date if usage warrants it. A transparent upgrade within CacheManager.Serialization.Json seems too risky especially in a distributed system where some old code and some new code would have to coexist for periods of time.
@VahidN do you want to make a PR for a new serializer? @MichaCo I think this would be a feature-request rather than a "compatibility with netcore30" ask/issue
any news on this?
I am having similar problem. Can anyone suggest a solution?
It'll definitely be it's own package and incompatible with newtonsoft json serialized Keys, so don't mix it in your deployments 😎
And sure, I'd be happy to see a pr for that, @ndrwrbgs or any one else
That's how I solved the problem within the app.
.NET Core 3x introduces the new built-in System.Text.Json namespace which has a higher performance than the
Newtonsoft.Json
dependency ofCacheManager.Serialization.Json
. It would be nice to add it later.